Skip to content

fix: Restore some react-hook lint rules#2084

Merged
kodiakhq[bot] merged 3 commits intomainfrom
drew/lint-restore
Apr 9, 2026
Merged

fix: Restore some react-hook lint rules#2084
kodiakhq[bot] merged 3 commits intomainfrom
drew/lint-restore

Conversation

@pulpdrew
Copy link
Copy Markdown
Contributor

@pulpdrew pulpdrew commented Apr 9, 2026

Summary

This PR:

Rule equivalence is documented here: https://www.eslint-react.xyz/docs/migrating-from-eslint-plugin-react-hooks

You can view current effective rule states with cd packages/app && npx eslint --inspect-config

How to test locally or on Vercel

Locally:

make ci-lint / make dev-lint

References

  • Linear Issue: HDX-3467
  • Related PRs:

@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Apr 9, 2026

⚠️ No Changeset found

Latest commit: a222dee

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added the review/tier-2 Low risk — AI review + quick human skim label Apr 9, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 9, 2026

🔵 Tier 2 — Low Risk

Small, isolated change with no API route or data model modifications.

Review process: AI review + quick human skim (target: 5–15 min). Reviewer validates AI assessment and checks for domain-specific concerns.
SLA: Resolve within 4 business hours.

Stats
  • Files changed: 11
  • Lines changed: 40
  • Branch: drew/lint-restore
  • Author: pulpdrew

To override this classification, remove the review/tier-2 label and apply a different review/tier-* label. Manual overrides are preserved on subsequent pushes.

@vercel
Copy link
Copy Markdown

vercel bot commented Apr 9, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
hyperdx-oss Ready Ready Preview, Comment Apr 9, 2026 7:02pm

Request Review

@pulpdrew pulpdrew changed the title Drew/lint restore fix: Restore some react-hook lint rules Apr 9, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 9, 2026

PR Review

  • ⚠️ Suppress comments use potentially non-standard rule names (react-hooks/refs, react-hooks/immutability, react-hooks/use-memo) — the standard eslint-plugin-react-hooks rules are only rules-of-hooks, exhaustive-deps, set-state-in-effect, set-state-in-render. If these are v7 additions, it's fine; if not, the comments are no-ops (the lines would still violate the equivalent @eslint-react rules, which are already disabled in config). Verify these rule names are real by running npx eslint --print-config on one of the affected files and checking if react-hooks/refs appears.

  • ⚠️ Some disabled @eslint-react rules lack direct react-hooks equivalents: @eslint-react/no-nested-component-definitions, @eslint-react/error-boundaries, @eslint-react/purity, @eslint-react/unsupported-syntax — the comment says "equivalent rules enabled in eslint-plugin-react-hooks" but these aren't duplicates of any standard react-hooks rule. If these were active in recommended-type-checked, they'll now go unenforced. Worth confirming these were also inactive under the old recommended + disable-conflict setup.

✅ No critical bugs or security issues. Config change is transparent and intentional; suppression patterns on useStableCallback, usePrevious, and RAF ref mutations are all well-known valid exceptions.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 9, 2026

E2E Test Results

All tests passed • 130 passed • 3 skipped • 1083s

Status Count
✅ Passed 130
❌ Failed 0
⚠️ Flaky 3
⏭️ Skipped 3

Tests ran across 4 shards in parallel.

View full report →

@kodiakhq kodiakhq bot merged commit 5de23e1 into main Apr 9, 2026
17 checks passed
@kodiakhq kodiakhq bot deleted the drew/lint-restore branch April 9, 2026 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

automerge review/tier-2 Low risk — AI review + quick human skim

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants